Skip to content

chore: Get rid of CannedResponse collection #35562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Mar 20, 2025
Merged

chore: Get rid of CannedResponse collection #35562

ggazzo merged 1 commit into from
Mar 20, 2025

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 20, 2025 •
edited by ggazzo
Loading

https://rocketchat.atlassian.net/browse/ARCH-1507

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 20, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.6.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35562/

Built to branch gh-pages at 2025-03-20 15:37 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.67%. Comparing base (a12d7f2) to head (8a8d77d).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35562   +/-   ##
========================================
  Coverage    59.67%   59.67%           
========================================
  Files         2826     2826           
  Lines        68309    68307    -2     
  Branches     15131    15131           
========================================
  Hits         40762    40762           
+ Misses       24936    24934    -2     
  Partials      2611     2611
Flag Coverage Δ
unit 75.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the chore/canned-response-collection branch from 8ec9cf0 to 8a8d77d Compare March 20, 2025 15:30
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 8a8d77d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo marked this pull request as ready for review March 20, 2025 17:15
@ggazzo ggazzo requested a review from a team as a code owner March 20, 2025 17:15
@ggazzo ggazzo added this to the 7.6.0 milestone Mar 20, 2025
@ggazzo ggazzo merged commit 8606cf6 into develop Mar 20, 2025
49 checks passed
@ggazzo ggazzo deleted the chore/canned-response-collection branch March 20, 2025 17:17
abhinavkrin pushed a commit that referenced this pull request Mar 24, 2025
@tassoevan @abhinavkrin
chore: Get rid of CannedResponse collection (#35562)
0acbe1a
abhinavkrin pushed a commit that referenced this pull request Mar 24, 2025
@tassoevan @abhinavkrin
chore: Get rid of CannedResponse collection (#35562)
26dea53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo